refactor(multisig)!: move from triggers to custom instructions #5217
DCO-2 / DCO
succeeded
Nov 15, 2024 in 1s
Check passed!
All commits are signed off, the check passed.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🟢 | e37bb4d | refactor!: move multisig logics to custom instruct... | Valid sign-off found |
| 🟢 | 00ec667 | fix: don't continue to grant a role on failing to ... | Valid sign-off found |
| 🟢 | a4ac5b0 | docs: fix doc test | Valid sign-off found |
| 🟢 | 657d3ad | chore: remove CanRegisterAnyTrigger `CanUnregist... |
Valid sign-off found |
| 🟢 | b158c59 | refactor: don't branch into visit and execute ... |
Valid sign-off found |
| 🟢 | 4eedd61 | refactor: clone and drop executor instance on recu... | Valid sign-off found |
| 🟢 | da8e7fb | fix: don't just execute arbitrary approved instruc... | Valid sign-off found |
| 🟢 | f54bd6e | fix: propagate executor verdict | Valid sign-off found |
| 🟢 | d75e932 | review: address up to #issuecomment-2453963837 |
Valid sign-off found |
| 🟢 | 0e8f7e6 | docs: Update readmes (#5219) | Valid sign-off found |
| 🟢 | 3c1888d | review: rename to visit_custom_instructions |
Valid sign-off found |
| 🟢 | bc1d497 | review: move to `{iroha_executor::default, iroha_e... | Valid sign-off found |
| 🟢 | bdd2a09 | review: minor updates since `#pullrequestreview-24... | Valid sign-off found |
| 🟢 | 255782e | review: submit a new account with metadata filled | Valid sign-off found |
| 🟢 | b0208cc | Revert "review: submit a new account with metadata... | Valid sign-off found |
| 🟢 | e95f743 | Merge branch 'main' into refactor/4930/custom_inst... | Skipped: sign-off not required in merge commit |
| 🟢 | 45b24d9 | fix: prevent a double grant to the registrant who ... | Valid sign-off found |
| 🟢 | e0a96f4 | review: minor updates since `#pullrequestreview-24... | Valid sign-off found |
| 🟢 | 183ff26 | review: nonzero quorum and transaction_ttl_ms |
Valid sign-off found |
| 🟢 | 70d51d0 | review: replace host.submit with `executor.visit... |
Valid sign-off found |
| 🟢 | 814b23b | review: minor updates since `#issuecomment-2463859... | Valid sign-off found |
| 🟢 | f54d3d9 | review: exclude custom instructions from schema `t... | Valid sign-off found |
| 🟢 | bd20861 | review: dedup and delegate MultisigRegister vali... |
Valid sign-off found |
| 🟢 | 17287d3 | review: dedup and delegate MultisigPropose valid... |
Valid sign-off found |
| 🟢 | d1a167c | Revert "review: dedup and delegate `MultisigPropos... | Valid sign-off found |
| 🟢 | e41ba88 | review: dedup and delegate MultisigApprove valid... |
Valid sign-off found |
| 🟢 | 35b3865 | Merge branch 'main' into refactor/4930/custom_inst... | Skipped: sign-off not required in merge commit |
| 🟢 | 0bb6250 | review: minor updates since `issuecomment-24684731... | Valid sign-off found |
| 🟢 | 2522e18 | review: visit_grant_account_role in `visit_regis... |
Valid sign-off found |
| 🟢 | 11800b6 | Revert "review: visit_grant_account_role in `vis... |
Valid sign-off found |
| 🟢 | 6eac0f6 | Merge branch 'main' into refactor/4930/custom_inst... | Skipped: sign-off not required in merge commit |
Loading