Skip to content

Commit

Permalink
Fix bug in groups widgets
Browse files Browse the repository at this point in the history
Refresh with no services selected would generate an
exception in the group selection/creation widget.
This just fixes the initialization.

Signed-off-by: Mic Bowman <mic.bowman@intel.com>
  • Loading branch information
cmickeyb committed May 28, 2024
1 parent 08bc8d9 commit b6cec81
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 5 deletions.
18 changes: 13 additions & 5 deletions exchange-contract/pdo/contracts/jupyter/groups.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,8 @@ def __init__(self, state : pbuilder.state.State, bindings : pbuilder.bindings.Bi
super().__init__([self.group_name, self.services, self.submit_button, self.feedback])

def reset_widget(self) :
self.services.reset_widget()
self.group_name.value = ''
self.services.reset_widget()

def submit_button_click(self, b) :
"""Create the provisioning services group
Expand Down Expand Up @@ -230,16 +230,20 @@ def update_preferred_list(self, change) :
if change['type'] == 'change' and change['name'] == 'value' :
value = self.preferred_service.value
selection = self.services.selection
if not selection :
selection = ['unknown']
if value not in selection :
value = selection[0]

self.preferred_service.options = selection
self.preferred_service.value = value

def reset_widget(self) :
self.services.reset_widget()
self.group_name.value = ''
self.preferred_service.value = ''

self.services.reset_widget()
self.preferred_service.options = ['unknown']
self.preferred_service.value = 'unknown'

def submit_button_click(self, b) :
"""Create the enclave services group
Expand Down Expand Up @@ -295,19 +299,23 @@ def update_persistent_list(self, change) :
if change['type'] == 'change' and change['name'] == 'value' :
value = self.persistent_service.value
selection = self.services.selection
if not selection :
selection = ['unknown']
if value not in selection :
value = selection[0]

self.persistent_service.options = selection
self.persistent_service.value = value

def reset_widget(self) :
self.services.reset_widget()
self.group_name.value = ''
self.persistent_service.value = ''
self.replicas.value = 2
self.duration.value = 120

self.services.reset_widget()
self.persistent_service.options = ['unknown']
self.persistent_service.value = 'unknown'

def submit_button_click(self, b) :
"""Create the storage services group
"""
Expand Down
1 change: 1 addition & 0 deletions exchange-contract/pdo/contracts/jupyter/services.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ def selection(self) :
return self.service_list.value

def reset_widget(self) :
self.service_list.options = self.create_service_list()
self.service_list.value = []

def create_service_list(self) :
Expand Down

0 comments on commit b6cec81

Please sign in to comment.