Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update value range from 2^40 to 2^100 #101

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Update value range from 2^40 to 2^100 #101

merged 2 commits into from
Nov 5, 2024

Conversation

jimthematrix
Copy link
Contributor

Anticipating that users and use cases might need a bigger range to accommodate the token practice to use 18 decimals. Using [0, 2^100) as the range allows a token economy built on zeto to have a trillion tokens each with 18 decimals.

Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
@Chengxuan
Copy link
Contributor

Chengxuan commented Nov 5, 2024

There should be some other places used 2^40, (could be for a different purpose). Worth double check whether it needs update as well

Checked all of them have been updated

@@ -14,23 +14,18 @@
// See the License for the specific language governing permissions and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the format of this file is not consistent with other files. It should be auto formatted by prettier when running the test using npm t

Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
@Chengxuan Chengxuan merged commit 34ca64b into main Nov 5, 2024
6 checks passed
@Chengxuan Chengxuan deleted the value-range branch November 5, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants