-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Key mgmt library and create a top-level sparse-merkle-tree library #26
Conversation
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
…m accounts Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 45.09% 45.74% +0.64%
==========================================
Files 14 16 +2
Lines 530 540 +10
==========================================
+ Hits 239 247 +8
- Misses 250 252 +2
Partials 41 41 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
PublicKey: privKey.Public(), | ||
PrivateKeyForZkp: privKeyForZkp, | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimthematrix I think we should just replace the key-manager.go under pkg
directory with this file for now along with its test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the key manager itself looks good to me, test coverage dropped so will need to be addressed. One solution is to combine the key-manager in internal
package with the one in pkg
package.
@jimthematrix feel free to address that in #25 if that makes things easier on your side.
thanks for the review @Chengxuan. there's coverage in the |
sparse-merkle-tree
keys
to demonstrate usage of existing encrypted keys capabilities for the Babyjubjub curve