Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename circuit inputs to have consistent naming conventions #35

Merged
merged 7 commits into from
Aug 13, 2024
Merged

Conversation

jimthematrix
Copy link
Contributor

No description provided.

Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 76.59574% with 22 lines in your changes missing coverage. Please review.

Project coverage is 59.57%. Comparing base (6544a70) to head (f19c3b9).

Files Patch % Lines
go-sdk/pkg/sparse-merkle-tree/node/node.go 0.00% 10 Missing ⚠️
go-sdk/pkg/utxo/utxo.go 28.57% 10 Missing ⚠️
go-sdk/internal/utxo/nonfungible.go 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   56.11%   59.57%   +3.45%     
==========================================
  Files          16       18       +2     
  Lines         540      606      +66     
==========================================
+ Hits          303      361      +58     
- Misses        197      205       +8     
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Copy link
Contributor

@Chengxuan Chengxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Chengxuan Chengxuan merged commit a7b9e39 into main Aug 13, 2024
7 checks passed
@Chengxuan Chengxuan deleted the naming branch August 13, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants