Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circuit compile and proving key gen enhancements #36

Merged
merged 10 commits into from
Aug 14, 2024
Merged

Conversation

jimthematrix
Copy link
Contributor

  • allow multiple circuits to be specified: -c anon -c anon_nullifier
  • allow compile only without generating the proving keys
  • update the js library to require CIRCUITS_ROOT rather than always assuming the circuit WASM to be in the local lib folder

Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.75%. Comparing base (a7b9e39) to head (1f80f1f).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   58.58%   63.75%   +5.17%     
==========================================
  Files          18       12       -6     
  Lines         606      538      -68     
==========================================
- Hits          355      343      -12     
+ Misses        209      152      -57     
- Partials       42       43       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
@@ -11,7 +11,7 @@ GOGC=30

all: test go-mod-tidy
test: deps lint
$(VGO) test ./internal/... ./pkg/... -cover -coverprofile=coverage.txt -covermode=atomic -timeout=30s ${TEST_ARGS}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the pkg folder now only contains interfaces and simple wrapper code, it does seem if we have tests in this folder, they'll mostly be boiler plate code.

As long as we can ensure other contributors know this convention, we should be fine.

Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Copy link
Contributor

@Chengxuan Chengxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a commit with some changes for first time users: 1f80f1f

@jimthematrix jimthematrix merged commit 7d97f65 into main Aug 14, 2024
7 checks passed
@jimthematrix jimthematrix deleted the circuit-gen branch August 14, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants