Fix deleting DBs in test for PSQL and document setup #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 68.95% 70.26% +1.30%
==========================================
Files 12 12
Lines 538 538
==========================================
+ Hits 371 378 +7
+ Misses 118 113 -5
+ Partials 49 47 -2 ☔ View full report in Codecov by Sentry. |
Chengxuan
reviewed
Aug 16, 2024
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Chengxuan
reviewed
Aug 16, 2024
go-sdk/integration-test/e2e_test.go
Outdated
Comment on lines
695
to
704
| func TestKeyManager(t *testing.T) { | ||
| keypair := decryptKeyStorev3(t) | ||
|
|
||
| keyEntry := key.NewKeyEntryFromPrivateKeyBytes([32]byte(keypair.PrivateKeyBytes())) | ||
| assert.NotNil(t, keyEntry) | ||
|
|
||
| assert.NotNil(t, keyEntry.PrivateKey) | ||
| assert.NotNil(t, keyEntry.PublicKey) | ||
| assert.NotNil(t, keyEntry.PrivateKeyForZkp) | ||
| } |
There was a problem hiding this comment.
was this an intended removal?
jimthematrix
approved these changes
Aug 16, 2024
|
sorry missed this in the review, you said:
where was this addressed? |
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Chengxuan
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to document that a Postgres instance needs to be running for the e2e of the go-sdk and make sure that the name of the table is not lowercased if not the tables will not get cleaned up after the test