Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update solidity compiler version; Remove local array sort() impl #98

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Update solidity compiler version; Remove local array sort() impl #98

merged 6 commits into from
Oct 29, 2024

Conversation

jimthematrix
Copy link
Contributor

@jimthematrix jimthematrix commented Oct 29, 2024 •
edited
Loading

  • underlying iden3 contracts dependencies updated to require Solidity 0.8.27
  • openzeppelin 5.1.0 now contains the Arrays.sort() utility, so removing the local implementation in Commonlib

@jimthematrix
Update solidity compiler version to 0.8.27
1685ef7 
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
@jimthematrix
Replace local array sort impl with openzeppelin util
fabacb4 
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
@jimthematrix jimthematrix changed the title Update solidity compiler version to 0.8.27 Update solidity compiler version; Remove local array sort() impl Oct 29, 2024
EnriqueL8
EnriqueL8 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimthematrix
Update golang version in actions setup to 1.23
488a60b 
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
@jimthematrix
Update to actions/setup-go@v5
991a4db 
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
@jimthematrix
install the latest version of golang-lint
6e92a7a 
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
@jimthematrix
install the v1.61.1 version of golang-lint
81aff0f 
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
@jimthematrix jimthematrix merged commit 6fdb52d into main Oct 29, 2024
6 checks passed
@jimthematrix jimthematrix deleted the hardhat-config branch October 29, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EnriqueL8 EnriqueL8 EnriqueL8 approved these changes

@awrichar awrichar awrichar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimthematrix @awrichar @EnriqueL8