Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Indy/Vdrtools #1298

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Remove Indy/Vdrtools #1298

wants to merge 15 commits into from

Conversation

gmulhearn
Copy link
Contributor

@gmulhearn gmulhearn commented Oct 11, 2024

Closes #1250

Other changes

I believe switching the pipelines has caused a whole lot of new tests to run in askar mode, so there's plenty of new test failures.

  • in aries_vcx, add support for expanding verkeys read from ledgers (abbreviated with ~ prefix, expanded into full verkey)
  • rm mysql wallet tests for now, i don't believe these ever worked for askar, we may need to look into it if we want to support it
  • askar wallet verify function only worked if the signer key is owned by the wallet; not useful for verify external signers
  • change the from_seed to from_secret_bytes in askar key generation (similar to fix: generate dids from indy seed secret bytes #1224 ), however i've taken the easy path out by just swapping it in-place
  • small issues with the unpack alg, where the reported sender_vk was missing 1 step of base58 decoding.
  • just using a dummy in-memory askar wallet for tests/agents currently. i left a TODO comment, but i think we can defer this for solving later, it will require consideration of how we want to make storage path configurable (previously we just let indy select some default location)
  • pin the mediator build image to our globally used rust toolchain version (1.79)

Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
…ed verkeys in legacy verkey resolution

Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
@gmulhearn gmulhearn marked this pull request as ready for review October 12, 2024 06:48
@gmulhearn
Copy link
Contributor Author

gmulhearn commented Oct 12, 2024

AATH status:

  • VCX <-> VCX
Failing scenarios:
  features/0160-connection.feature:52  Inviter Sends invitation for one agent second agent tries after connection
  features/0160-connection.feature:69  Inviter Sends invitation for one agent second agent tries during first share phase
  features/0793-peer-did.feature:31  Establish a connection with DID Exchange between two agents utilizing qualified did:peer DIDs -- @1.2 
  features/0793-peer-did.feature:55  Establish a connection with DID Exchange between two agents utilizing qualified did:peer DIDs with responder not set to send qualified Peer DIDs -- @1.1 
  features/0793-peer-did.feature:79  Establish a connection with DID Exchange between two agents utilizing qualified did:peer DIDs with responder set to send a different Peer DID method -- @1.2 

3 features passed, 3 failed, 9 skipped
29 scenarios passed, 5 failed, 126 skipped
252 steps passed, 5 failed, 1126 skipped, 0 undefined
Took 8m33.934s
  • VCX <-> ACAPY
    Struggling to set up full environment, but i sampled all 4 RFC0036 tests we enrol in, and they are passing

Signed-off-by: gmulhearn <gmulhearn@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of legacy indy-sdk crates and dependencies
1 participant