0.9.0 errata, move to tmio for tuweni dep #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyschulte
force-pushed
the
bugfix/remove-errant-tuweni-runtime-dep
branch
3 times, most recently
from
4a86403
to
9978d1c
Compare
pinges
previously requested changes
Jun 27, 2024
| o_len.setValue(0); | ||
| } else { | ||
| err_len.setValue(0); | ||
| } | ||
| return ret; | ||
| } | ||
|
|
||
| public int findFirstTrailingZeroIndex(byte[] array) { |
There was a problem hiding this comment.
this is implemented in the Utils class. I think this is not needed ...
You are even using the Utils implementation further up :-)
There was a problem hiding this comment.
where? would love to DRY this out, but I don't see the usage you are talking about
There was a problem hiding this comment.
found and removed ;). thx
There was a problem hiding this comment.
This implementation has no usages, and can now be removed.
pinges
reviewed
Jun 27, 2024
gnark/src/main/java/org/hyperledger/besu/nativelib/gnark/LibGnarkEIP196.java
Outdated
Show resolved
Hide resolved
Signed-off-by: garyschulte <garyschulte@gmail.com>
…ed ECC precompiles Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
bugfix/remove-errant-tuweni-runtime-dep
branch
from
8aca5a1
to
209d3e6
Compare
Signed-off-by: garyschulte <garyschulte@gmail.com>
jflo
approved these changes
Jun 28, 2024
| o_len.setValue(0); | ||
| } else { | ||
| err_len.setValue(0); | ||
| } | ||
| return ret; | ||
| } | ||
|
|
||
| public int findFirstTrailingZeroIndex(byte[] array) { |
There was a problem hiding this comment.
This implementation has no usages, and can now be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove tuweni as a runtime dependency for gnark-crypto, back to testImplementation dependency. Also, bump tuweni dep to tmio.
In besu we have to specifically exclude this dependency from the gnark dep to prevent conflicts with besu's version of tuweni.