Bugfix/eip 196 edge case #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyschulte
force-pushed
the
bugfix/eip-196-edge-case
branch
from
d308b8d
to
df3a53c
Compare
pinges
reviewed
Jun 28, 2024
| @@ -100,7 +121,17 @@ func eip196altbn128G1Mul(javaInputBuf, javaOutputBuf, javaErrorBuf *C.char, cInp | |||
| errorBuf := castErrorBuffer(javaErrorBuf, errorLen) | |||
|
|
|||
| if inputLen < EIP196PreallocateForG1 { | |||
| // if we do not have complete input, return 0 | |||
|
|
|||
| // check the X point and return an error if it is in the field, edge case | |||
There was a problem hiding this comment.
Suggested change
| // check the X point and return an error if it is in the field, edge case | |
| // check the X point and return an error if it is not in the field, edge case |
| // check we have input size sufficient for a G1Affine | ||
| if inputLen < EIP196PreallocateForG1 { | ||
|
|
||
| // if not, check the X point and return an error if it is in the field, edge case |
There was a problem hiding this comment.
Suggested change
| // if not, check the X point and return an error if it is in the field, edge case | |
| // if not, check the X point and return an error if it is not in the field, edge case |
This PR to resolve a reference test failure. I agree it is weird behavior. IMO all malformed inputs should return an error. reference test fail: |
…t case, make tests pickier about expected errors Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
bugfix/eip-196-edge-case
branch
from
df3a53c
to
f8dfeab
Compare
jflo
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for a weird (imo) EIP-196 expectation that a malformed/incomplete g1 point should return an error if the X value is readable, but not in the field; whereas a malformed/incomplete g1 point will otherwise return 0