Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(plugin-htlc-eth-besu): stop using the deprecated api.encodePacked #2531

Open
petermetz opened this issue Jul 2, 2023 · 2 comments
Open

refactor(plugin-htlc-eth-besu): stop using the deprecated api.encodePacked #2531

petermetz opened this issue Jul 2, 2023 · 2 comments
Assignees
@petermetz
Labels
Besu good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P4 Priority 4: Low Security Related to existing or potential security vulnerabilities

Comments

@petermetz
Copy link
Member

petermetz commented Jul 2, 2023 •
edited
Loading

Description

Stop using the abi.encodePacked() call in the packages/cactus-plugin-htlc-eth-besu/src/main/solidity/contracts/HashTimeLock.sol contract because that method has been deprecated according to [1]

[1] ethereum/solidity#11593

Acceptance Criteria

  1. Tests are still passing
  2. The new encoding call does not make this a breaking change, e.g. the outputs are consistent so that the test cases do not need to be changed to keep passing after the contract have been re-deployed.
  3. Make sure to update the compiled .json artifact of the .sol source code file so that the tests do end up using the new revision of the .sol code.

cc: @RafaelAPB
@petermetz petermetz added good-first-issue Good for newcomers Besu Security Related to existing or potential security vulnerabilities Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. good-first-issue-300-advanced P4 Priority 4: Low labels Jul 2, 2023
@petermetz petermetz self-assigned this Jul 2, 2023
@RafaelAPB
Copy link
Contributor

I'll do this task

@RafaelAPB RafaelAPB mentioned this issue Jul 6, 2023
Merged
@RafaelAPB
Copy link
Contributor

Done, PR #2538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
Besu good-first-issue Good for newcomers good-first-issue-300-advanced Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. P4 Priority 4: Low Security Related to existing or potential security vulnerabilities
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petermetz @RafaelAPB