refactor(plugin-htlc-eth-besu): stop using the deprecated api.encodePacked #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelAPB
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
RafaelAPB
force-pushed
the
refactor-2531
branch
2 times, most recently
from
6be04cf
to
6f8e056
Compare
petermetz
requested changes
Jul 6, 2023
There was a problem hiding this comment.
@RafaelAPB LGTM but could you please recompile the contracts with https://marketplace.visualstudio.com/items?itemName=JuanBlanco.solidity so that the .json artifacts structure is not changed at the same time?
takeutak
approved these changes
Jul 10, 2023
petermetz
approved these changes
Jul 18, 2023
|
LGTM (Peter has already approved to not approving it, as we need 3 approvals from different orgs) |
petermetz
force-pushed
the
refactor-2531
branch
3 times, most recently
from
f0a4fbd
to
fc1dd62
Compare
…acked 1. Add tests to vanilla HashTimeLock 2. Replace abi.encodePacked by abi.encode 3. Compile and replace generated ABIs (for HashTimeLock and PrivateHashTimeLock) Peter's additional changes: 1. Replace all the function calls that were missed. 2. Also update the hash function from sha256 to keccak256 where it was missed 3. Recompile the contracts again but with the VScode extension that gives them the additional properties with their metadata like the contract name that we use during deployment. 4. Modify the test case so that it computes the hash for the contract ID purely in Javascript instead of doing a call to the EVM to do the same. Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: Rafael Belchior <rafael.belchior@tecnico.ulisboa.pt> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
|
@petermetz thank you for updating the contracts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2531
cc @petermetz