Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use golangci-lint #134

Merged
merged 1 commit into from
May 22, 2024
Merged

Use golangci-lint #134

merged 1 commit into from
May 22, 2024

Conversation

bestbeforetoday
Copy link
Member

No description provided.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
@bestbeforetoday bestbeforetoday marked this pull request as ready for review May 19, 2024 20:51
@bestbeforetoday bestbeforetoday requested a review from a team as a code owner May 19, 2024 20:51
@bestbeforetoday bestbeforetoday enabled auto-merge (squash) May 19, 2024 20:52
Copy link
Contributor

@denyeart denyeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, thank you. If it goes well we should do it for core Fabric as well.

@bestbeforetoday bestbeforetoday merged commit 2bd813b into hyperledger:main May 22, 2024
9 checks passed
@bestbeforetoday bestbeforetoday deleted the lint branch May 22, 2024 18:02
@bestbeforetoday
Copy link
Member Author

I've been using it for quite a while in fabric-gateway and fabric-admin-sdk. There is quite a lot of choice on the linters to run. Note that the staticcheck built into golangci-lint is not the same (and not endorsed by) the official staticcheck linter, which is why I disable the golangci-lint version and run staticcheck explicitly.

@bestbeforetoday bestbeforetoday mentioned this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants