-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use caching CI builds #762
Use caching CI builds #762
Conversation
83d393a
to
c19e41b
Compare
a0064d9
to
4dc644e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR. I've tested it locally and it works great!
Could you please check my suggestions. We should also document this "option" in the config.mk
.
@mbrandenburger thanks for your time to review. All changes applied and now the PR is ready 🙂 |
9f80310
to
e3e4f24
Compare
@osamamagdy thanks for the updates. Could you please rebase/squash your changes. I think we keep one commit for the |
969a940
to
daa25b3
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've noticed those whitespaces. Otherwise this looks very good to me.
01da46b
to
9870332
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
9870332
to
2e5dc65
Compare
@mbrandenburger Thanks, all done now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Thanks!
Fixes #753
This PR activates caching on a directory on the runner and mounting it to the go location where dependencies are installed inside the container building the app