add support for docker compose v2 (fix #730) #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: uniform64 <jiny2048@gmail.com>
uniform641
force-pushed
the
docker-compose-v2
branch
from
8ed64b1
to
eaa7ee1
Compare
some missing places in the previous commit Signed-off-by: uniform64 <jiny2048@gmail.com>
|
@uniform641 @lehors Apologies for the late review, but I think this change will break things when using "podman-compose". Could you please comment and/or add another PR to make it work with "podman-compose"? Otherwise we may need to revert the commit. |
|
Ah I had meant to check this out actually and then forgot and couldn't remember why I hadn't merged it already. I'm getting soft in the brains. :-( |
|
Sorry I didn't know about |
denyeart
pushed a commit
that referenced
this pull request
Dec 12, 2023
|
Thanks, I've merged #1147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux servers with docker engine installed through docker document could not run
network.shsuccessfully due to docker compose version compatibility. The default docker engine doesn't supportdocker-composecommand.As the docker document suggest,
docker composeis preferred to use in docker compose V2.This PR adds support for docker compose V2 version. It uses
docker composecommand if it findsdocker-composecommand fails to execute.