Refactor test-network post-decoupling fabric-tools image #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satota2
force-pushed
the
refactor-post-decoupling-fabric-tools
branch
from
c5e7f6a
to
ad86ed9
Compare
|
@Mergifyio rebase |
❌ Unable to rebase: user
|
This patch aims to refactor the test-network in several aspects, following the decoupling of the fabric-tools image from fabric-samples. - Rename 'test_network_home' env var to 'TEST_NETWORK_HOME' - Dedicate the intermediate artifacts related to configtx to channel-artifacts - Refer to core.yaml in fabric-samples/config, similar to org1 and 2, instead of adding a new core file - Remove unnecessary functions and comments for CLI container - Other minor modifications Signed-off-by: Tatsuya Sato <tatsuya.sato.so@hitachi.com>
satota2
force-pushed
the
refactor-post-decoupling-fabric-tools
branch
from
ad86ed9
to
a7da183
Compare
|
Hello @denyeart, |
|
Thank you @SamYuan1990 and @satota2 , apologies for the delay! |
denyeart
approved these changes
Apr 18, 2024
|
@denyeart Thank you for reviewing and merging the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aims to refactor the test-network in several aspects, the initial PR (#1186) for the decoupling of the fabric-tools image from fabric-samples.
For context, please refer to the discussions on that PR.
Related Issues: