[docker-test] TLS support in the all-in-one test image node with external connectivity

[dean-amar]

Type of change

• Test update

Description

• Adding an all-in-one test-node-based integration test that verifies correct TLS connectivity between the components and external clients.
• Removing unused code.

Related issues

• resolves TLS support in the all-in-one test image #176

[mbrandenburger]

Thanks @dean-amar - great PR!

[mbrandenburger]

I am wondering if there is a better way t set the name of the image based on whatever tag are? Maybe latests and let the make script either build?

[dean-amar]

We can simplify this by making the image tag configurable via the Makefile.
In the Makefile, we will change the version to a mutable variable:

version ?= 0.0.2
export TEST_NODE_TAG := $(version)

Then, in the tests, we derive the full image name based on the tag:

var testNodeImage = func() string {
	base := "icr.io/cbdc/committer-test-node:"
	if tag := os.Getenv("TEST_NODE_TAG"); tag != "" {
		return base + tag
	}
	return base + "latest"
}()

Would that work?

[mbrandenburger]

Yes, this would be good.

Looking at the makefile, we also use the ${image_namespace} to build the image name. I guess we should also consider this in the test?

build-test-node-image: build-arch build-test-genesis-block
	${docker_cmd} build $(docker_build_flags) \
		-f $(dockerfile_test_node_dir)/Dockerfile \
		-t ${image_namespace}/committer-test-node:${version} \
		--build-arg ARCHBIN_PATH=${arch_output_dir_rel} \
		. $(docker_push_arg)

Wouldn't it be simpler to just define the full name in the makefile and export it, so we can use it's name via the env variable in the test.

For example:

test_node_image_full ?= ${image_namespace}/committer-test-node:${version}

build-test-node-image: build-arch build-test-genesis-block
	${docker_cmd} build $(docker_build_flags) \
		-f $(dockerfile_test_node_dir)/Dockerfile \
		-t ${test_node_image_full} \
		--build-arg ARCHBIN_PATH=${arch_output_dir_rel} \
		. $(docker_push_arg)

And as you suggested in the test ...

var testNodeImage = func() string {
	default := "icr.io/cbdc/committer-test-node:latest" // not sure if this default is reasonable
	return cmp.Or(os.Getenv("test_node_image_full"), default)
}()

WDYT?

[dean-amar]

Yeah, that's great! I'll add it to the next commit.

[liran-funaro]

LGTM. Mostly minor comments.

[mbrandenburger]

LGTM