Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add/remove orderer docs #4390

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

semil
Copy link
Contributor

@semil semil commented Aug 21, 2023

Docs regarding the addition and removal of an orderer to/from existing cluster or channel.

Type of change

  • Documentation update

Related issues

Issue: #4332

@semil semil requested review from a team as code owners August 21, 2023 09:47
@yacovm yacovm requested a review from denyeart August 21, 2023 09:50
@denyeart
Copy link
Contributor

This is a much needed addition. Before I do a detailed review, let me ask if you've seen the similar "Adding an Org to a Channel" tutorial - https://hyperledger-fabric.readthedocs.io/en/latest/channel_update_tutorial.html

"Adding an Org to a Channel" tutorial has been improved over time and has a good mix of conceptual explanation and tutorial instructions. It may make sense to use the same format and copy/paste some of the background information, and then extend/replace with your "adding a consenter" content. For example "Adding an Org to a Channel" tutorial assumes that the reader already has test network up and running, and then walks the reader through how to extend it, while your tutorial has them generate everything including for the 5th consenter and then bring up a new channel. Following the "Adding an Org to a Channel" tutorial approach may make more sense for an "adding" tutorial. Also it would be nice if the sections aligned to each other and similar wording was used. Although you may have deviated on purpose? Just wanted to get your initial thoughts on making these two tutorials similar in nature, or if you intentionally wanted it to be a little different.

Signed-off-by: Emil Elizarov <emil.elizarov@ibm.com>
@yacovm yacovm merged commit 17b77cf into hyperledger:main Aug 24, 2023
14 checks passed
@yacovm
Copy link
Contributor

yacovm commented Aug 24, 2023

I merged this, @denyeart please take a look and if you want to make changes, feel free to make a new PR

@satota2
Copy link
Contributor

satota2 commented Aug 24, 2023

Hello @yacovm @denyeart @semil

I merged this, @denyeart please take a look and if you want to make changes, feel free to make a new PR

I'm been trying out the BFT samples in fabric-samples recently.
As part of this process, I also tried to add an orderer following the instructions in this document.

I didn't get a chance to comment on the recent pull request in time, but I've identified some areas from a user's perspective that might benefit from further improvements. I'll be submitting a new PR with these suggestions shortly.

@satota2 satota2 mentioned this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants