bump github.com/syndtr/goleveldb to 126854af5e6d #5019
Conversation
| if value == nil { | ||
| value = []byte{} | ||
| } |
There was a problem hiding this comment.
Why is this change needed? Doesn't it change the behavior in a way that may impact callers?
There was a problem hiding this comment.
Without this change, everything stops working.
Previously the goleveldb library returned []byte{}
now it returns []byte(nil)
And in the fabric returning nil it is considered that no key is found in the database
Instead of finding and fixing all the places where this behavior is used, I simulated our old behavior.
I should probably add a comment
There was a problem hiding this comment.
here's the commit that made this change
There was a problem hiding this comment.
Thanks @pfi79 , the original author @manish-sethi will review this one.
There was a problem hiding this comment.
LGTM, given the change in leveldb behavior.
Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>
No description provided.