Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tx completion tracking #113

Merged
merged 12 commits into from
Sep 15, 2023
Merged

Remove tx completion tracking #113

merged 12 commits into from
Sep 15, 2023

Conversation

jimthematrix
Copy link
Contributor

Fabric receipts are notified via golang channels, so no need to use the tracker to calculate receipt polling time

Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern applies to this one as #112 Looks like these changes were made off of that branch

Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Merging #113 (332569c) into main (37e40f3) will increase coverage by 0.24%.
The diff coverage is 18.75%.

❗ Current head 332569c differs from pull request most recent head 745174f. Consider uploading reports for the commit 745174f to get more accurate results

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   68.21%   68.45%   +0.24%     
==========================================
  Files          47       47              
  Lines        4527     4489      -38     
==========================================
- Hits         3088     3073      -15     
+ Misses       1243     1214      -29     
- Partials      196      202       +6     
Impacted Files Coverage Δ
cmd/debugrouter.go 0.00% <0.00%> (ø)
internal/utils/tlsutils.go 31.03% <0.00%> (ø)
internal/tx/txprocessor.go 14.58% <20.00%> (+2.95%) ⬆️
cmd/fabconnect.go 62.03% <25.00%> (-8.97%) ⬇️
internal/rest/router.go 69.36% <25.00%> (-0.64%) ⬇️
internal/fabric/client/identity.go 69.60% <45.45%> (-1.24%) ⬇️
internal/events/test_helper.go 90.90% <100.00%> (-3.04%) ⬇️
internal/events/webhooks.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@jimthematrix
Copy link
Contributor Author

the concern was addressed in the PR #112, and merged into this one.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@nguyer nguyer merged commit b3b5114 into hyperledger:main Sep 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants