Docker image nonroot user #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cari Albritton <cari.albritton@kaleido.io>
Signed-off-by: Cari Albritton <cari.albritton@kaleido.io>
onelapahead
reviewed
Oct 12, 2023
| WORKDIR /fabconnect | ||
| COPY --from=fabconnect-builder /fabconnect/fabconnect ./ | ||
| COPY --from=fabconnect-builder --chown=1001:0 /fabconnect/fabconnect ./ |
There was a problem hiding this comment.
we might not need this one here bc of the permissions of /usr/bin are opened up to other linux users normally
Codecov Report
@@ Coverage Diff @@
## main #119 +/- ##
=======================================
Coverage 68.71% 68.71%
=======================================
Files 47 47
Lines 4482 4482
=======================================
Hits 3080 3080
Misses 1209 1209
Partials 193 193 |
nguyer
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.