Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker build to PR builds; fix paths in Dockerfile #122

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

jimthematrix
Copy link
Contributor

No description provided.

Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7300295) 68.71% compared to head (6cceb12) 68.65%.

❗ Current head 6cceb12 differs from pull request most recent head 6359310. Consider uploading reports for the commit 6359310 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   68.71%   68.65%   -0.07%     
==========================================
  Files          47       47              
  Lines        4482     4482              
==========================================
- Hits         3080     3077       -3     
- Misses       1207     1210       +3     
  Partials      195      195              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! Sorry you ran into trouble with this.

@nguyer nguyer merged commit 73fc96b into hyperledger:main Jan 25, 2024
3 checks passed
@nguyer nguyer deleted the build-docker branch January 25, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants