fix: TLS and extend FileServer OpenAPI #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EnriqueL8
commented
May 3, 2024
EnriqueL8
commented
- Enable TLS on the HTTP Server correctly
- Nest FileServer OpenAPI under /api/*filepath
- Add JSON OpenAPI version
- Update the mocks to fix
EnriqueL8
force-pushed
the
fixes
branch
2 times, most recently
from
39c988c
to
dafe33a
Compare
- Enable TLS on the HTTP Server correctly - Nest FileServer OpenAPI under /api/*filepath - Add JSON OpenAPI version - Update the mocks to fix Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
jimthematrix
requested changes
May 8, 2024
| if tlsConfig != nil { | ||
| // Under the covers it will use g.srv.TLSConfig | ||
| // If the cert and key file are not present, it will use the CA from the TLSConfig | ||
| err = g.srv.ListenAndServeTLS(g.config.HTTP.TLS.ClientCertsFile, g.config.HTTP.TLS.ClientKeyFile) |
There was a problem hiding this comment.
The ClientCertsFile and ClientKeyFile are for the Kafka client component. To collect configurations for the server cert and key files, we should define new config properties. Maybe call them config.HTTP.TLS.ServerCertsFile and config.HTTP.TLS.ServerKeyFile, with the JSON property names accordingly
There was a problem hiding this comment.
This configuration is under the HTTP section already , we have a separate configuration for Kafka here
firefly-fabconnect/internal/conf/conf.go
Lines 161 to 165 in 73fc96b
jimthematrix
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.