Update to latest OpenZeppelin base contracts #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
commented
Mar 1, 2024
| @@ -112,14 +105,13 @@ contract ERC721WithData is Context, Ownable, ERC721, IERC721WithData { | |||
| } | |||
|
|
|||
| function tokenURI(uint256 tokenId) public view virtual override returns (string memory) { | |||
| require(_exists(tokenId), 'ERC721WithData: Token does not exist'); | |||
|
|
|||
| _requireOwned(tokenId); | |||
| string memory uri = _tokenURIs[tokenId]; | |||
| return uri; | |||
| } | |||
|
|
|||
| function _setTokenURI(uint256 tokenId, string memory _tokenURI) internal { | |||
There was a problem hiding this comment.
I didn't do it here, but I wonder if we should be inheriting https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC721/extensions/ERC721URIStorage.sol
|
Closed in favor of #149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.