Update CODEOWNERS #100
Merged
Update CODEOWNERS #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Chengxuan
requested review from
peterbroadhurst,
nguyer and
awrichar
as code owners
Codecov Report
@@ Coverage Diff @@
## main #100 +/- ##
==========================================
- Coverage 99.94% 99.94% -0.01%
==========================================
Files 79 79
Lines 5188 5171 -17
==========================================
- Hits 5185 5168 -17
Misses 3 3 |
nguyer
suggested changes
Sep 13, 2023
CODEOWNERS
Outdated
| @@ -1,7 +1,7 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| # FireFly Core Maintainers | |||
| * @peterbroadhurst @nguyer @awrichar | |||
| # FireFly transaction manager maintainers | |||
There was a problem hiding this comment.
Not sure the comment is necessary anymore given that the team name is self-describing
CODEOWNERS
Outdated
Comment on lines
5
to
7
| # FireFly Documentation Maintainers | ||
| /docs @peterbroadhurst @nguyer @awrichar @nickgaski No newline at end of file | ||
| /docs @peterbroadhurst @nguyer @awrichar @nickgaski |
There was a problem hiding this comment.
I think we can drop this section. We started with the idea of separate docs maintainers early on, but in practice have never used that idea.
|
Do you mind also updating https://github.com/hyperledger/firefly-transaction-manager/blob/main/MAINTAINERS.md To match the format in https://github.com/hyperledger/firefly/blob/main/MAINTAINERS.md And add yourself? 🙂 |
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
nguyer
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update code owners file to use the github team
@nguyer Not sure what to do with the Doc maintainers, there isn't a github team for them.
@nickgaski also lost access to the repo.