Require policy engines to map failures during submission to idempotency #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nRejected bool Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 79 80 +1
Lines 5177 5182 +5
=======================================
+ Hits 5174 5179 +5
Misses 3 3 ☔ View full report in Codecov by Sentry. |
awrichar
reviewed
Dec 21, 2023
| case ErrorReasonInvalidInputs, | ||
| ErrorReasonTransactionReverted, | ||
| ErrorReasonInsufficientFunds: | ||
| // These reason codes are considered as rejections of the transaction - see ffcapi.SubmissionError |
There was a problem hiding this comment.
This feels like the most significant part of the change. This list seems good from what I can tell though.
awrichar
approved these changes
Dec 21, 2023
This was referenced Dec 21, 2023
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See hyperledger/firefly#1435
The implementation here:
ErrorReasoninformation that FFCAPI implementations already providesubmissionRejectedboolean on the response back to core (sofalsemeans it is retryable)firefly-common