Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix propagation of blockNumber to EVMConnect (and batch logging tweak) #109

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Fix propagation of blockNumber to EVMConnect (and batch logging tweak) #109

merged 2 commits into from
Feb 14, 2024

Conversation

peterbroadhurst
Copy link
Contributor

  • We weren't passing blockNumber down
  • We were assuming on the internal struct it had to be a number, where FFTM should not be opinionated
    • Noting that for EVM it can be "latest"

@peterbroadhurst
More logging
1e7b7ae 
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst
Fix blockNumber propagation to eth_call
26834f1 
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst peterbroadhurst requested a review from a team as a code owner February 14, 2024 20:30
@nguyer nguyer merged commit 9e50b94 into main Feb 14, 2024
2 checks passed
@nguyer nguyer deleted the sql-logging branch February 14, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyer nguyer nguyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterbroadhurst @nguyer