-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: race condition when reading and writing to inflight queue #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Chengxuan
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments on the loggings. The use of read locks looks good.
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: Enrique Lacal <enriquelacal@gmail.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io> Signed-off-by: Enrique Lacal <enriquelacal@gmail.com>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Chengxuan
reviewed
Apr 24, 2024
Chengxuan
reviewed
Apr 24, 2024
Chengxuan
reviewed
Apr 24, 2024
Chengxuan
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The policy loop frequently read and writes from the inflight queue, more specifically:
updateInFlightSet
and remove the ones that have completed.When loading new transactions, the code will take a copy and override the inflight queue with an empty array. If another thread was reading from such array, most often iterating to find a specific inflight tx it wouldn't find it.
This PR alongside with adding extra logging to help diagnose this sort of issues, adds a read/write mutex for the inflight queue and a mutex for each pendingState to be thread safe. Creates read locks when iterating and reading from the queue, write lock in a single place where we remove or load new transactions in queue and a mutex on the pendingState when we read or modify it.
Draft: as running another performance test for the latest commit