Update mockery version #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-semenyuk
force-pushed
the
update_mockery
branch
3 times, most recently
from
f6e181e
to
aa04562
Compare
Chengxuan
reviewed
May 23, 2024
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/hyperledger/firefly-transaction-manager | |||
|
|
|||
| go 1.21 | |||
There was a problem hiding this comment.
We usually do golang version update across Firefly repos and don't normally pin to a specific patch version. e.g., it should be go 1.22 in this example
@EnriqueL8 is there a plan for the minor version 22 yet?
There was a problem hiding this comment.
I haven't set a plan yet for it, will keep that in mind - @alex-semenyuk is it strictly needed for this change?
There was a problem hiding this comment.
@EnriqueL8 sorry for delay, yes, we can move without version update, so updated PR
Btw noticed that there is intermittently failed test #127
Signed-off-by: alexey semenyuk <alexsemenyuk88@gmail.com>
alex-semenyuk
force-pushed
the
update_mockery
branch
4 times, most recently
from
e2c0ca4
to
48085be
Compare
Signed-off-by: alexey semenyuk <alexsemenyuk88@gmail.com>
alex-semenyuk
force-pushed
the
update_mockery
branch
from
48085be
to
573f26d
Compare
Chengxuan
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue on
make mocksExplicit define version instead of latest for mockery as recommended https://vektra.github.io/mockery/latest/installation/