fix: deleting listeners from event stream pagination #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
|
Tested locally with a custom build of evmconnect in FF CLI |
peterbroadhurst
requested changes
Jun 6, 2024
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
|
Thanks for the pointer @peterbroadhurst - radically simpler now |
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
peterbroadhurst
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting an event stream that has more listeners that the default pagination limit, it was failing due to incorrect logic of deleting the listener before using it as "offset" to query the next set of listeners to delete.
This PR fixes this by querying the next set before deleting the last one.