Do not keep dispatching after block listener falls behind #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
matthew1001
approved these changes
Sep 3, 2024
| @@ -194,12 +194,12 @@ func (cbl *confirmedBlockListener) processBlockNotification(block *apitypes.Bloc | |||
| var dispatchHead *apitypes.BlockInfo | |||
| if len(cbl.newHeadToAdd) > 0 { | |||
| // we've snuck in multiple notifications while the dispatcher is busy... don't add indefinitely to this list | |||
| if len(cbl.newHeadToAdd) > 10 /* not considered worth adding/explaining a tuning property for this */ { | |||
| if len(cbl.newHeadToAdd) >= 10 /* not considered worth adding/explaining a tuning property for this */ { | |||
There was a problem hiding this comment.
Looks good to me - just not sure why the change from > to >=?
There was a problem hiding this comment.
11 just felt weird
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127
When I spent time breaking down the test to remove timing conditions, I found I was driving the logic below the new
returnI added in invalid ways. So thereturnfelt much better to leave the existing queue in flight, and then the dispatcher will still fall back togetBlockByNumber