Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confirmations incremental dispatch #94

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fix confirmations incremental dispatch #94

merged 1 commit into from
Jul 10, 2023

Conversation

peterbroadhurst
Copy link
Contributor

@peterbroadhurst peterbroadhurst commented Jul 8, 2023

~In PR chain with #93 ~
~Also contains commit from #96 ~
Rebased on main with 93/96 merged to aid review

I found that we were re-dispatching the whole set of confirmations each time, in the incremental case where NewFork: false

@codecov-commenter
Copy link

Codecov Report

Merging #94 (eb44387) into main (e6fe782) will decrease coverage by 0.04%.
The diff coverage is 98.81%.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   99.98%   99.94%   -0.04%     
==========================================
  Files          77       79       +2     
  Lines        5004     5153     +149     
==========================================
+ Hits         5003     5150     +147     
- Misses          1        3       +2     
Impacted Files Coverage Δ
internal/persistence/persistence.go 100.00% <ø> (ø)
...nternal/persistence/postgres/transaction_writer.go 99.25% <90.47%> (-0.75%) ⬇️
internal/confirmations/confirmations.go 100.00% <100.00%> (ø)
...ternal/persistence/dbmigration/leveldb2postgres.go 100.00% <100.00%> (ø)
internal/persistence/dbmigration/migration.go 100.00% <100.00%> (ø)
...nternal/persistence/leveldb/leveldb_persistence.go 100.00% <100.00%> (ø)
internal/persistence/postgres/sqlpersistence.go 100.00% <100.00%> (ø)
internal/persistence/postgres/transactions.go 100.00% <100.00%> (ø)
pkg/txhandler/simple/policyloop.go 100.00% <100.00%> (ø)

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst
Copy link
Contributor Author

Rebased on main

@nguyer nguyer merged commit bdeb537 into main Jul 10, 2023
@nguyer nguyer deleted the diag-ldb-conf branch July 10, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants