Fixing a nonce conflict issue when the cached nonce expired. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Chengxuan
requested review from
peterbroadhurst,
nguyer and
awrichar
as code owners
nguyer
suggested changes
Aug 2, 2023
Chengxuan
commented
Aug 2, 2023
Chengxuan
commented
Aug 2, 2023
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Chengxuan
force-pushed
the
nonce-state-timeout-fix
branch
from
523bb3a
to
84b845b
Compare
nguyer
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem when two different batches of transaction inserts happen in parallel, one of them will read the incorrect nonce back from the DB + the nonce callback when the cached nonce expires.
The fix in the PR is to check the expired cached nonce first to avoid pending transactions that have clashing nonces between them.