Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow to verify the OSX latest version #129

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

cdivitotawela
Copy link
Contributor

Workflow triggers when a push is made to main branch which is common with a version update. Installs Besu on OSX runner and check the installed version is same as the version configured in besu.rb file. This verifies that published version is the latest version installed on OSX using Homebrew

fixes Consensys/protocol-misc#957

Workflow triggers when a push is made to main branch which is common with a version update. Installs Besu on OSX runner
and check the installed version is same as the version configured in besu.rb file. This verifies that published
version is the latest version installed on OSX using Homebrew

Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I wonder how reliable it is that it would be ready for install immediately upon the push to main branch or if sometimes there is a delay? In that case you would run it manually if it fails the first time for this reason?

@cdivitotawela
Copy link
Contributor Author

LGTM, I wonder how reliable it is that it would be ready for install immediately upon the push to main branch or if sometimes there is a delay? In that case you would run it manually if it fails the first time for this reason?

I feel it should work immediately.

@cdivitotawela cdivitotawela merged commit a1c10e0 into main Aug 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants