Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make fixes to ed25519 sign method + improve tests #195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elribonazo
Copy link
Contributor

Description:

After some investigation, we are returning a hex encoded buffer with the signature in JS which causes compatibility issues across SDK and we are also improving the test coverage for ed25519 by using the same values on all platforms we test

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

…ex causing compatibility issues and improve tests

Signed-off-by: Javier Ribó <elribonazo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant