-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI]: Update Iroha 1 branch workflow #185
Conversation
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
.github/workflows/iroha1.yml
Outdated
push: | ||
branches: | ||
- iroha1-main | ||
tags: | ||
- '*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
push: | |
branches: | |
- iroha1-main | |
tags: | |
- '*' | |
push: | |
tags: | |
- 'v1*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should differentiate between publishing a release and merging into main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
releases should only be built from tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scope of this PR is to fix the branch name and the workflow file name (to avoid confusion), the rest I left as it was
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but we should split our CI into these workflows:
- workflow that runs on every merge to
main
- workflow that runs on every merge to
iroha1-main
- workflow that runs on every
v1*
tag - workflow that runs on every
v2*
tag
I think these should all be separate CI files, but maybe you can make them into 2 files (one for merge and one for tags) if the corresponding workflows are the same for iroha1
and iroha2
should you merge this into |
It's unclear to me at this point (not a GitHub CI expert), seems like it doesn't matter as long as the target branches are specified in the workflow files. |
then let's merge it into |
.github/workflows/iroha1.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you renamed the file, shouldn't you delete the old file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's strange, renaming the file should have deleted the old version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you didn't commit the deleted file
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Fix branch name, rename workflow file