Trim Hypervisor trait
#924
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
force-pushed
the
vm_trait_new
branch
3 times, most recently
from
81f0d54 to
62fad87
Compare
ludfjig
added
the
kind/refactor
ludfjig
force-pushed
the
vm_trait_new
branch
17 times, most recently
from
1562f26 to
edc7f00
Compare
ludfjig
force-pushed
the
vm_trait_new
branch
4 times, most recently
from
f6337f9 to
350b8e0
Compare
jsturtevant
reviewed
Nov 7, 2025
ludfjig
force-pushed
the
vm_trait_new
branch
18 times, most recently
from
fa21515 to
0a033d6
Compare
ludfjig
force-pushed
the
vm_trait_new
branch
from
0a033d6 to
5a116e5
Compare
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
trait Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
force-pushed
the
vm_trait_new
branch
from
5a116e5 to
ee7545e
Compare
ludfjig
commented
Nov 26, 2025
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
Contributor
Author
There was a problem hiding this comment.
Indeed these tests are removed (on purpose). Turns out it does not even run the CODE below... I am planning on re-adding some unit tests in next PR
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
force-pushed
the
vm_trait_new
branch
from
c07d874 to
11db597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Hypervisortrait. It's now a minimal trait for common functionality of a minimal Vm. It abstracts over differences in kvm, mshv, whp. This traits only knows things like set/get registers, run, but nothing about guest functions or hyperlight specifics.HyperlightVmstruct. This is a new struct that contains thedyn Hypervisorabove, as well as things like guest_ptr, rsp, memory-regions, gdb connections, etc. HyperlightVm knows about initialization, dispatching guest calls, gdb-debugging etc, guest-tracing, whichHypervisortrait doesn't. All code that was previously duplicated in kvm/mshv/whp now lives in HyperlightVm.When reviewing, new file hyperlight_vm.rs should be compared against old kvm.rs, hyperv_linux.rs, hyperv_windows.rs. Note: this PR should not modify/introduce new code (as best as possible). It primarily just moves code around and factors out duplicate code.
Closes #465, #904