Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-1259: Android display matching problem as table #1052

Merged
merged 12 commits into from
May 21, 2024
Merged

ALTAPPS-1259: Android display matching problem as table #1052

merged 12 commits into from
May 21, 2024

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented May 20, 2024 •
edited
Loading

YouTrack Issues:
ALTAPPS-1259

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Use TableSelectionItemAdapterDelegate in MatchingStepQuizFormDelegate;
  • Update matching step quiz swap logic;
  • Update Table options bottom sheet style;
  • Update Table step quiz skeleton.

@XanderZhu XanderZhu self-assigned this May 20, 2024
@XanderZhu XanderZhu added the android Android module task label May 20, 2024
@XanderZhu XanderZhu added this to the 1.58 milestone May 20, 2024
@github-actions github-actions bot added the shared Shared module task label May 20, 2024
@XanderZhu XanderZhu requested a review from ivan-magda May 20, 2024 15:48
@XanderZhu XanderZhu added the awaiting review Pull Request is awaiting code reviews label May 20, 2024
@XanderZhu

This comment was marked as resolved.

Sign in to view
@XanderZhu XanderZhu marked this pull request as ready for review May 20, 2024 15:49
@ivan-magda ivan-magda removed the awaiting review Pull Request is awaiting code reviews label May 21, 2024
@ivan-magda ivan-magda merged commit f2b01b6 into develop May 21, 2024
13 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-1259/Android-display-matching-problem-as-table branch May 21, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-magda ivan-magda ivan-magda approved these changes

Assignees

@XanderZhu XanderZhu

Labels
android Android module task shared Shared module task
Projects
None yet
Milestone
1.58
Development

Successfully merging this pull request may close these issues.
2 participants
@XanderZhu @ivan-magda