Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTAPPS-1253: Android topic completion screen #1063

Merged

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented May 27, 2024

YouTrack Issues:
ALTAPPS-1253

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Implement TopicCompletedDialogFragment;
  • Use MediaPlayer to play a video on the background;
  • Update compileSdk to 34 to use screenshot API.

@XanderZhu XanderZhu added this to the 1.59 milestone May 27, 2024
@XanderZhu XanderZhu self-assigned this May 27, 2024
@github-actions github-actions bot added the android Android module task label May 27, 2024
@github-actions github-actions bot added the shared Shared module task label May 28, 2024
@XanderZhu XanderZhu marked this pull request as ready for review May 28, 2024 13:06
@XanderZhu XanderZhu requested a review from ivan-magda May 28, 2024 13:06
@XanderZhu XanderZhu added the awaiting review Pull Request is awaiting code reviews label May 28, 2024
@ivan-magda ivan-magda added ready to pull Pull Request is ready to merge and removed awaiting review Pull Request is awaiting code reviews labels May 28, 2024
@XanderZhu XanderZhu removed the ready to pull Pull Request is ready to merge label May 28, 2024
@XanderZhu XanderZhu merged commit 956c026 into develop May 28, 2024
13 checks passed
@XanderZhu XanderZhu deleted the feature/ALTAPPS-1253/Android-topic-completion-screen branch May 28, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android module task shared Shared module task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants