Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared fix logging analytic events #1076

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Shared fix logging analytic events #1076

merged 2 commits into from
Jun 5, 2024

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Jun 5, 2024 •
edited
Loading

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Fix setting Result instead of Boolean to analytic property

@XanderZhu XanderZhu added bug Something isn't working shared Shared module task labels Jun 5, 2024
@XanderZhu XanderZhu added this to the 1.60.1 milestone Jun 5, 2024
@XanderZhu XanderZhu marked this pull request as ready for review June 5, 2024 12:30
@XanderZhu XanderZhu requested a review from ivan-magda June 5, 2024 12:30
@XanderZhu XanderZhu added the awaiting review Pull Request is awaiting code reviews label Jun 5, 2024
ivan-magda
ivan-magda approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@ivan-magda ivan-magda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked on iOS, it works 👍

@github-actions github-actions bot added the ios iOS module task label Jun 5, 2024
@ivan-magda ivan-magda merged commit d153617 into hotfix/1.60.1 Jun 5, 2024
6 of 8 checks passed
@ivan-magda ivan-magda deleted the feature/Fix_setting_can_make_payments_analytic_property branch June 5, 2024 12:33
@ivan-magda ivan-magda removed the awaiting review Pull Request is awaiting code reviews label Jun 5, 2024
@XanderZhu
Copy link
Contributor Author

Checked on iOS, it works 👍

Yeah, on Android too

@ivan-magda ivan-magda mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-magda ivan-magda ivan-magda approved these changes

Assignees

@XanderZhu XanderZhu

Labels
bug Something isn't working ios iOS module task shared Shared module task
Projects
None yet
Milestone
1.60.1
Development

Successfully merging this pull request may close these issues.
2 participants
@XanderZhu @ivan-magda