Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-1282: Shared, iOS comments section #1097

Merged
merged 16 commits into from
Jul 5, 2024
Merged

ALTAPPS-1282: Shared, iOS comments section #1097

merged 16 commits into from
Jul 5, 2024

Conversation

ivan-magda
Copy link
Member

@ivan-magda ivan-magda commented Jul 3, 2024 •
edited
Loading

YouTrack Issues:
#ALTAPPS-1282

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • Sentry Performance Monitoring of screen loading is added for new screens;
  • View analytics events are added for new screens;
  • New analytics events are documented;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  1. Adds StepFeature.Action.ViewAction.NavigateTo.CommentsScreen
  2. Adds CommentsScreenComponent
  3. Implements comments screen on iOS

@ivan-magda ivan-magda added this to the 1.63 milestone Jul 3, 2024
@ivan-magda ivan-magda self-assigned this Jul 3, 2024
@github-actions github-actions bot added shared Shared module task ios iOS module task android Android module task labels Jul 3, 2024
@ivan-magda ivan-magda requested a review from XanderZhu July 4, 2024 03:15
@ivan-magda ivan-magda added the awaiting review Pull Request is awaiting code reviews label Jul 4, 2024
@XanderZhu XanderZhu added ready to pull Pull Request is ready to merge and removed awaiting review Pull Request is awaiting code reviews labels Jul 4, 2024
@ivan-magda ivan-magda removed the ready to pull Pull Request is ready to merge label Jul 5, 2024
@ivan-magda ivan-magda merged commit cf3cb9a into develop Jul 5, 2024
12 of 13 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-1282/Shared-iOS-Comments-section branch July 5, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XanderZhu XanderZhu XanderZhu approved these changes

Assignees

@ivan-magda ivan-magda

Labels
android Android module task ios iOS module task shared Shared module task
Projects
None yet
Milestone
1.63
Development

Successfully merging this pull request may close these issues.
2 participants
@ivan-magda @XanderZhu