Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTAPPS-1290: Shared, iOS improve track switching flow #1110

Conversation

ivan-magda
Copy link
Member

@ivan-magda ivan-magda commented Jul 19, 2024

YouTrack Issues:
#ALTAPPS-1290

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • New analytics events are documented;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  1. Adds StudyPlanScreenFeature.Message.ChangeTrackButtonClicked and StudyPlanScreenFeature.Action.ViewAction.NavigateTo.TrackSelectionScreen
  2. Adds TrackSelectionDetailsDataComponent to store tracks selection counts
  3. Updates the track list sorting in TrackSelectionListViewStateMapper

@ivan-magda ivan-magda added this to the 1.65 milestone Jul 19, 2024
@ivan-magda ivan-magda self-assigned this Jul 19, 2024
@github-actions github-actions bot added shared Shared module task ios iOS module task android Android module task labels Jul 19, 2024
}
.associateBy { it.id }
private suspend fun handleFetchTracksAction(
action: InternalAction.FetchTracks,

Check warning

Code scanning / detekt

Function parameter is unused and should be removed. Warning

Function parameter action is unused.
@ivan-magda ivan-magda marked this pull request as ready for review July 20, 2024 04:06
@ivan-magda ivan-magda requested a review from XanderZhu July 20, 2024 04:12
@ivan-magda ivan-magda added the awaiting review Pull Request is awaiting code reviews label Jul 20, 2024
@XanderZhu XanderZhu added ready to pull Pull Request is ready to merge and removed awaiting review Pull Request is awaiting code reviews labels Jul 22, 2024
@ivan-magda ivan-magda removed the ready to pull Pull Request is ready to merge label Jul 23, 2024
@ivan-magda ivan-magda merged commit 9940fa7 into develop Jul 23, 2024
13 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-1290/Shared-iOS-Improve-track-switching-flow branch July 23, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android module task ios iOS module task shared Shared module task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants