Skip to content

ALTAPPS-1301: Shared, Android root topics section pagination #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

XanderZhu
Copy link
Contributor

@XanderZhu XanderZhu commented Jul 24, 2024

YouTrack Issues:
ALTAPPS-1301

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • New analytics events are documented;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  • Add StudyPlanWidgetFeature.State.getActivitiesToBeLoaded & StudyPlanSection.getActivitiesToBeLoaded to determine which activities are still not loaded;
  • Add StudyPlanWidgetFeature.Message.LoadMoreActivitiesClicked;
  • Add isNextPageLoadingShowed & isLoadAllTopicsButtonShown to the StudyPlanWidgetViewState.SectionContent.Content;
  • Split StudyPlanWidgetFeature.ContentStatus to StudyPlanWidgetFeature.SectionStatus & StudyPlanWidgetViewState.SectionContentStatus; add FIRST_PAGE_LOADING NEXT_PAGE_LOADING, PAGE_LOADED, ALL_PAGES_LOADED to describe pages loading;
  • Remove replacing old section activities with new loaded activities for RootTopics section.

@github-actions github-actions bot added shared Shared module task android Android module task labels Jul 24, 2024
@XanderZhu XanderZhu added this to the 1.65 milestone Jul 24, 2024
@github-actions github-actions bot added the ios iOS module task label Jul 24, 2024
@XanderZhu XanderZhu requested a review from ivan-magda July 24, 2024 22:55
@XanderZhu XanderZhu marked this pull request as ready for review July 24, 2024 22:55
@XanderZhu XanderZhu added the awaiting review Pull Request is awaiting code reviews label Jul 24, 2024
@ivan-magda ivan-magda changed the title ALTAPPS-1301: Shared android root topics section pagination ALTAPPS-1301: Shared, Android root topics section pagination Jul 25, 2024
@ivan-magda ivan-magda removed the awaiting review Pull Request is awaiting code reviews label Jul 25, 2024
@ivan-magda ivan-magda merged commit e5d9915 into develop Jul 25, 2024
13 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-1301/Shared-android-root-topics-section-pagination branch July 25, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android module task ios iOS module task shared Shared module task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants