Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-1308: Shared speed up code submissions evaluation for beginners by removing linters #1125

Merged
merged 2 commits into from
Jul 29, 2024
Merged

ALTAPPS-1308: Shared speed up code submissions evaluation for beginners by removing linters #1125

merged 2 commits into from
Jul 29, 2024

Conversation

ivan-magda
Copy link
Member

YouTrack Issues:
#ALTAPPS-1308

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  1. Adds "lint_profile": null in the reply for code problems.
  2. Our JSON configuration does not encode defaults (code, docs), so I made Reply.lintProfile with a String? type and a default value of an empty string to be able to serialize null.

@ivan-magda ivan-magda added this to the 1.66 milestone Jul 26, 2024
@ivan-magda ivan-magda self-assigned this Jul 26, 2024
@github-actions github-actions bot added shared Shared module task ios iOS module task labels Jul 26, 2024
@ivan-magda ivan-magda requested a review from XanderZhu July 26, 2024 03:50
@ivan-magda ivan-magda added the awaiting review Pull Request is awaiting code reviews label Jul 26, 2024
@XanderZhu XanderZhu added ready to pull Pull Request is ready to merge and removed awaiting review Pull Request is awaiting code reviews labels Jul 26, 2024
@ivan-magda ivan-magda removed the ready to pull Pull Request is ready to merge label Jul 29, 2024
@ivan-magda ivan-magda merged commit 55fcf36 into develop Jul 29, 2024
14 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-1308/Shared-Speed-up-code-submissions-evaluation-for-beginners-by-removing-linters branch July 29, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XanderZhu XanderZhu XanderZhu approved these changes

Assignees

@ivan-magda ivan-magda

Labels
ios iOS module task shared Shared module task
Projects
None yet
Milestone
1.66
Development

Successfully merging this pull request may close these issues.
2 participants
@ivan-magda @XanderZhu