Remove compass-mixins dependency #3272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The immediate problem this dependency causes is that it it fails to build with the current version of node-sass (see Igosuki/compass-mixins#84) which in turn means that H cannot be built with Node 6.0. Removing this dependency allows the node-sass dependency to be unpinned so that the current version can be used. The primary functionality that compass-mixins was used for was vendor prefixing, which is now taken care of by autoprefixer, plus CSS fixes for browsers which we no longer support (IE < 10). For the remaining handful of mixins for resets and color mixing which we are still using, this commit just extracts the few lines of code for each from the compass documentation and includes it directly in our SCSS files.
|
Seems ok here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The immediate problem this dependency causes is that it it fails to
build with the current version of node-sass (see
Igosuki/compass-mixins#84) which in turn means
that H cannot be built with Node 6.0. Removing this dependency allows
the node-sass dependency to be unpinned so that the current version
can be used.
The primary functionality that compass-mixins was used for was vendor
prefixing, which is now taken care of by autoprefixer, plus CSS fixes
for browsers which we no longer support (IE < 10).
For the remaining handful of mixins for resets and color mixing which we
are still using, this commit just extracts the few lines of code for
each from the compass documentation and includes it directly in our SCSS
files.