-
-
Notifications
You must be signed in to change notification settings - Fork 522
Nvidia: Partial rewrite to bring up to date with new developments #1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, but I have a few questions:
- Does suspend work now on
nvidia-open-dkms
? - Does
hardware.nvidia.powerManagement.enable
handle the kernelParam as well now? - Is the
NVreg_RegistryDwords
fix no longer needed? __GLX_VENDOR_LIBRARY_NAME
?
Additionally, mentions of Hyprland/Wayland/Xwayland or some other project should be capitalized.
For your last point, sure, I will have a look. |
Okay then, lmk when this is ready. |
okie dokie, I've made some changes. Let me know if anything is still missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's alright. @gulafaran you have Nvidia iirc, do you mind checking this as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good refactor, I think its overall an improvement.
Left some suggestions.
I re-added the nuclear method, but upon conversation with @gulafaran i decided to remove it again as originally intended. It's not a very good workaround tbh, stuff should be fixed in Hyprland, Electron, and Chromium now. (thanks tom, ikalco, plasmapower, and others) |
Most of those options are either removed or not really working either since a long time ago , https://forums.developer.nvidia.com/t/kernel-module-option-nvreg-registrydwords-for-powermizerenable-doesnt-work-on-530-41-03/247610 |
Still waiting on Vaxry's response, but should be ready to squash and merge once that's done :) |
oops didnt notice the ping |
@fufexan should be ready for any final reviews now. edit: also squashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda long review but I felt like a lot of stuff was overly verbose. We want to keep the wiki as simple as possible.
Thanks lol, I incorporated the changes, let me know what you think. EDIT: lol there was even more hiding, I had a look at those and they all seemed very reasonable and much better than the way it was already written / I had written it. Not sure why you lost contributor attribution to this PR. Sorry >< |
Nvidia: Capitalise mentions of Hyprland and Wayland Nvidia: correct some misinformation on my end, add back enabling modeset as it wasn't actually enabled by default, reword slightly Nvidia: modesetting is also enabled by default on NixOS 🐐 Nvidia: provide commonly used names for the 3 driver types Co-authored-by: Nathan Ollerenshaw <chrome@stupendous.net> Nvidia: re-add nuclear method to fix flickering, other minor changes Nvidia: re-remove nuclear method to fix flickering Nvidia: modify spotify-launcher part to suggest modifying file in ~ instead of /etc Nvidia: reword section about DKMS vs non-DKMS Still suggest to use dkms as it simplifies configuration for multi-kernel / non-lts/default kernel setups, but also explain that the non-DKMS packages are available Nvidia: add small disclaimer about trying closed drivers if suspend is still not working Nvidia: correct spotify-launcher config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Hello again, this is the second time I've done this lol
I was getting a little tired of having people in the Discord keep complaining about electron flickering, when it has been pretty much solved for a while now, so it pushed me to just rewrite most of the Nvidia page on the Wiki to hopefully mitigate some of that.
There are a few opinionated changes I've made here. I felt they were what was best for the page, as they either contained information which were for Nvidia drivers so old they shouldn't even be using Wayland, or they were unneeded in my eyes (i.e. fixing flickering with those weird power management options)
I'm still unsure as to whether I should keep some of this "legacy" info here. i.e., containing info about how to enable modeset and fbdev, when they've also been enabled by default for a few months. Let me know what y'all think and whether or not we should keep this info.
Any criticism is welcome, I want this page to be as easy to read as possible since we have a lot of Nvidia users (including me) and most of the issues being reported are just the same thing over and over again at this point.
CC @fufexan since fuf reviewed my last PR about this (#601)