Skip to content

Alttab #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 24, 2025
Merged

Alttab #1037

merged 11 commits into from
Apr 24, 2025

Conversation

aphelei
Copy link
Contributor

@aphelei aphelei commented Apr 16, 2025

add alt tab behaviour

testing needed please

@vaxerski vaxerski requested a review from fufexan April 17, 2025 00:23
Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The disable.sh script is referenced but not provided.

@aphelei
Copy link
Contributor Author

aphelei commented Apr 23, 2025

yeah sorry

Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but

  1. I'd add #!/usr/bin/env bash shebangs at the top of scripts
  2. You can add ```bash {filename="alttab.sh"} to also display the filename inside the code block
  3. Explicitly list the dependencies.
  4. Use $XDG_CONFIG_HOME instead of ~/.config, as it's more idiomatic. Besides, ~ does not always expand to $HOME inside scripts.
  5. Mention that foot --server has to be running.

@aphelei
Copy link
Contributor Author

aphelei commented Apr 24, 2025

Generally looks good, but

1. I'd add `#!/usr/bin/env bash` shebangs at the top of scripts

idk why it's necessary but ok

2. You can add ```bash {filename="alttab.sh"} to also display the filename inside the code block

done

3. Explicitly list the dependencies.

ok

4. Use `$XDG_CONFIG_HOME` instead of `~/.config`, as it's more idiomatic. Besides, `~` does not always expand to `$HOME` inside scripts.

works without that but ok

5. Mention that `foot --server` _has_ to be running.

added an exec-once

Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fufexan fufexan marked this pull request as ready for review April 24, 2025 14:47
@fufexan fufexan merged commit d585414 into hyprwm:main Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants