Input fade out timeout #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaideiaDilemma
commented
Mar 1, 2024
Comment on lines
-202
to
+225
| return dots.currentAmount != PASSLEN || data.opacity < 1.0 || forceReload; | ||
| return dots.currentAmount != PASSLEN || fade.animated || forceReload; |
There was a problem hiding this comment.
data.opacity < 1.0 did not really make sense to me. Did I miss something about that?
There was a problem hiding this comment.
uhh I think the renderer will take care of that anyways I think
|
This way it rerenders during the timeout though. Should this be implemented via a callback instead? |
Now the dots kind of fade into the placeholder text on a failure.
PaideiaDilemma
force-pushed
the
fade-out-timeout
branch
from
53ed451 to
d46d437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
A bit of a follow up to #98
This handles the placeholder text in combination with fadeOnEmpty better, as it allows the user to specify a timeout for fading out the password field.
It now behaves the same weather an authentication failure happens or weather I empty the password input field (via ESC or Backspace).
This is how it looks with a default timeout of 1 second:
fade_out_timeout.mp4