misc: add git commit hash to --version when not on tag v${VERSION}#590
Merged
vaxerski merged 1 commit intohyprwm:mainfrom Dec 20, 2024
Merged
misc: add git commit hash to --version when not on tag v${VERSION}#590vaxerski merged 1 commit intohyprwm:mainfrom
vaxerski merged 1 commit intohyprwm:mainfrom
Conversation
vaxerski
reviewed
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opted for doing it straight in cmake, since we don't need all the stuff that
generateVersion.shin Hyprland does.This only appends the short git hash when we are not on the tag v${VERSION} where ${VERSION} is the content of the VERSION file.
Merging this implies that
Hyprlock version 0.6.0can be actual v0.6.0, 0588306 or d12b4a7, since those 2 commit don't have this yet